[PK-59] BE/INFRA: fix invalid PAYMENT_IBAN placeholder + sync docker-compose default #18

Merged
forge-admin merged 2 commits from agent/be-dev/bc414f7f into main 2026-05-17 03:06:49 +00:00
Owner

Fixuje PK-59.

Zmeny

  • be/.env.example: PAYMENT_IBAN z SK6811000000002612345678 (mod-97 = 45, invalid) na SK2411000000002612345678 (banka 1100, mod-97 = 1, valid). Pridaný komentár vysvetľujúci invariant.
  • docker-compose.yml: pridané PAYMENT_IBAN, PAYMENT_RECIPIENT_NAME, PAYMENT_SS defaulty synchronizované s be/.env.example.
  • be/tests/pay-by-square.test.ts: regresny test, ktorý parsuje be/.env.example a docker-compose.yml a tvrdí mod-97 valid IBAN + zhodu hodnôt.

Verifikácia

npx vitest run → 18 files / 198 tests passed.

Head: c217d75.

Fixuje [PK-59](mention://issue/75de2fb5-ce02-4e97-95dc-8d3264428ca9). ## Zmeny - `be/.env.example`: `PAYMENT_IBAN` z `SK6811000000002612345678` (mod-97 = 45, invalid) na `SK2411000000002612345678` (banka 1100, mod-97 = 1, valid). Pridaný komentár vysvetľujúci invariant. - `docker-compose.yml`: pridané `PAYMENT_IBAN`, `PAYMENT_RECIPIENT_NAME`, `PAYMENT_SS` defaulty synchronizované s `be/.env.example`. - `be/tests/pay-by-square.test.ts`: regresny test, ktorý parsuje `be/.env.example` a `docker-compose.yml` a tvrdí mod-97 valid IBAN + zhodu hodnôt. ## Verifikácia `npx vitest run` → 18 files / 198 tests passed. Head: `c217d75`.
Aktuálny placeholder SK6811000000002612345678 má mod-97 = 45, takže
isValidIban() v lib/pay-by-square.ts ho odmietne a GET /api/orders/:id
/payment-qr končí na 500 invalid_iban. FE potom schová celú QR sekciu
(payment-not-configured fallback sa nezasiahne, lebo BE nevracia 503),
čo je regresia AC pre PK-49.

Mením placeholder na SK2411000000002612345678 (banka 1100, mod-97 = 1),
overený matematicky. Pridávam regresný test, ktorý parsuje .env.example
a verifikuje mod-97 cez existujúci isValidIban().

Pre PK-58 vetvu: docker-compose default \${PAYMENT_IBAN:-SK6811...} treba
synchronne aktualizovať pred merge, aby compose stack bez root-level .env
nezdedil starý invalid IBAN.

Co-authored-by: multica-agent <github@multica.ai>
Doplnenie review-feedbacku z PK-59: docker-compose.yml teraz predáva
PAYMENT_IBAN/RECIPIENT_NAME/PAYMENT_SS do BE s defaultmi sync-nutými
s be/.env.example. PAYMENT_IBAN default je SK2411000000002612345678
(banka 1100, mod-97 = 1, valid) namiesto starého invalid placeholderu
SK6811000000002612345678 navrhovaného v PK-58 vetve.

Regresny test rozsireny o assertion ze docker-compose.yml PAYMENT_IBAN
default sa zhoduje s be/.env.example — CI zachyti, ak niekto desync-ne
oba defaulty.

Bez tejto zmeny by sa po merge PK-58 do main pri `docker compose up`
bez root .env znova pouzil invalid IBAN a 500 invalid_iban → /objednavka
schova celu QR sekciu (regresia PK-49 AC).

Co-authored-by: multica-agent <github@multica.ai>
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forge-admin/masox-eshop!18
No description provided.